r104681 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104680‎ | r104681 | r104682 >
Date:13:54, 30 November 2011
Author:gwicke
Status:deferred
Tags:
Comment:
Let another test pass by swapping the default order of italic/bold for '''''.
Minor test output cosmetics.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/parser/pegParser.pegjs.txt (modified) (history)
  • /trunk/extensions/VisualEditor/tests/parser/parserTests.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/tests/parser/parserTests.js
@@ -197,7 +197,7 @@
198198
199199 function printTitle() {
200200 console.log('=====================================================');
201 - console.log(item.title);
 201+ console.log('FAILED: ' + item.title);
202202 console.log(item.comments.join('\n'));
203203 console.log("INPUT:");
204204 console.log(item.input + "\n");
Index: trunk/extensions/VisualEditor/modules/parser/pegParser.pegjs.txt
@@ -240,11 +240,11 @@
241241 case 5:
242242 // order does not matter here, will be fixed
243243 // by HTML parser backend
 244+ italics.push(i + inserted);
 245+ out.push({type: 'QUOTE', value: "''"});
 246+ inserted++;
244247 bolds.push(i + inserted);
245248 out.push({type: 'QUOTE', value: "'''"});
246 - inserted++;
247 - italics.push(i + inserted);
248 - out.push({type: 'QUOTE', value: "''"});
249249 break;
250250 default: // longer than 5, only use the last 5 ticks
251251 token.value = "'''''";
@@ -255,11 +255,11 @@
256256 out.push({type: 'TEXT', value: newvalue});
257257 inserted++;
258258 }
 259+ italics.push(i + inserted);
 260+ out.push({type: 'QUOTE', value: "''"});
 261+ inserted++;
259262 bolds.push(i + inserted);
260263 out.push({type: 'QUOTE', value: "'''"});
261 - inserted++;
262 - italics.push(i + inserted);
263 - out.push({type: 'QUOTE', value: "''"});
264264 break;
265265 }
266266 break;

Status & tagging log