r104599 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104598‎ | r104599 | r104600 >
Date:21:47, 29 November 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r104580;
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php
@@ -102,7 +102,10 @@
103103 $this->m_dataitem = new SMWDIGeoCoord( $parsedCoords );
104104 } else {
105105 $this->addError( wfMsgExt( 'maps_unrecognized_coords', array( 'parsemag' ), $coordinates, 1 ) );
106 - $this->m_dataitem = new SMWDIGeoCoord( array(0, 0) ); // make sure this is always set
 106+
 107+ // Make sure this is always set
 108+ // TODO: Why is this needed?!
 109+ $this->m_dataitem = new SMWDIGeoCoord( array( 'lat' => 0, 'lon' => 0 ) );
107110 }
108111 }
109112
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -143,7 +143,7 @@
144144 if ( $this->fatalErrorMsg === false ) {
145145 global $wgParser;
146146
147 - $params = $this->m_params;
 147+ $params = $this->params;
148148
149149 $queryHandler = new SMQueryHandler( $res, $outputmode );
150150 $queryHandler->setShowSubject( $params['showtitle'] );
@@ -176,8 +176,10 @@
177177 SMWOutputs::requireResource( $resourceModule );
178178 }
179179
 180+ $result = $this->getMapHTML( $params, $wgParser, $mapName ) . $this->getJSON( $params, $wgParser, $mapName );
 181+
180182 return array(
181 - $this->getMapHTML( $params, $wgParser, $mapName ) . $this->getJSON( $params, $wgParser, $mapName ),
 183+ $result,
182184 'noparse' => true,
183185 'isHTML' => true
184186 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104580some initial work on bug 32698jeroendedauw19:03, 29 November 2011