r104569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104568‎ | r104569 | r104570 >
Date:15:39, 29 November 2011
Author:cneubauer
Status:deferred
Tags:
Comment:
Followon to r104568. Get rid of my comments in the code.
Modified paths:
  • /trunk/extensions/SpecialUploadLocal/SpecialUploadLocal.php (modified) (history)
  • /trunk/extensions/SpecialUploadLocal/UploadLocalForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SpecialUploadLocal/SpecialUploadLocal.php
@@ -26,9 +26,7 @@
2727 $wgSpecialPages['SpecialUploadLocal'] = 'SpecialUploadLocal';
2828 $wgExtensionMessagesFiles['SpecialUploadLocal'] = dirname( __FILE__ ) . '/SpecialUploadLocal.i18n.php';
2929 $wgAutoloadClasses[ 'SpecialUploadLocal' ] = dirname( __FILE__ ) . '/SpecialUploadLocal_body.php';
30 -/** (CSN) 27 Oct 2011 - Need to add new class for 1.17.0 */
3130 $wgAutoloadClasses[ 'WebRequestUploadLocal' ] = dirname( __FILE__ ) . '/WebRequestUploadLocal.php';
32 -/* (CSN) end mod **/
3331
3432 $wgUploadLocalDirectory = $IP . '/extensions/SpecialUploadLocal/data';
3533
Index: trunk/extensions/SpecialUploadLocal/UploadLocalForm.php
@@ -21,16 +21,13 @@
2222 $name = $dir . $filename;
2323
2424 $this->upload = new UploadFromFile();
25 -/** (CSN) 27 Oct 2011 - For 1.17.0, we need a request object */
2625 $fileInfo = array(
2726 'name' => $dest,
2827 'size' => filesize( $name ),
2928 'tmp_name' => $name,
3029 'error' => 0
3130 );
32 - //$this->upload->initialize( $dest, $name, filesize( $name ) );
3331 $this->upload->initialize( $name, new WebRequestUploadLocal( true, $fileInfo ) );
34 -/* (CSN) end mod **/
3532 }
3633
3734 function processUpload( $user ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104568Update for 1.17. This probably breaks compatibility with <= 1.15 and possibl...cneubauer15:33, 29 November 2011

Status & tagging log