r104556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104555‎ | r104556 | r104557 >
Date:12:28, 29 November 2011
Author:petrb
Status:deferred
Tags:
Comment:
removed unused globals and fixed comment
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.status.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.status.php
@@ -158,7 +158,7 @@
159159 * @return bool
160160 */
161161 public static function updateStatus() {
162 - global $wgUser, $wgOnlineStatusBarDefaultOffline, $wgOnlineStatusBarTrackIpUsers, $wgOnlineStatusBarDefaultEnabled;
 162+ global $wgUser, $wgOnlineStatusBarDefaultOffline;
163163 // if anon users are not tracked and user is anon leave it
164164 if (!OnlineStatusBar::isValid( $wgUser )) {
165165 return false;
@@ -183,7 +183,7 @@
184184 }
185185
186186 /**
187 - * Delete old records from the table, this function is called frequently to keep the table it as small as possible
 187+ * Delete old records from the table, this function is called frequently to keep the table as small as possible
188188 * it's also possible to disable this function to set automatic job in cron to do that
189189 * @return int
190190 */
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.php
@@ -95,6 +95,7 @@
9696 'offline' => 'statusred.png',
9797 );
9898
 99+// For memcached
99100 define( 'ONLINESTATUSBAR_DELAYED_CACHE', 'd' );
100101 define( 'ONLINESTATUSBAR_NORMAL_CACHE', 'n' );
101102

Status & tagging log