r104540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104539‎ | r104540 | r104541 >
Date:03:15, 29 November 2011
Author:khorn
Status:ok
Tags:
Comment:
r104539
Cleaning up my lame array merging.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -1535,17 +1535,15 @@
15361536 'date' => time(),
15371537 'gateway_txn_id' => $this->getTransactionGatewayTxnID(),
15381538 'correlation-id' => $this->getCorrelationID(),
1539 - 'payment_method' => $this->getData_Raw('payment_method')
 1539+ 'payment_method' => $this->getData_Raw( 'payment_method' )
15401540 );
15411541
15421542 $raw_data = array();
1543 - foreach ($stomp_fields as $field){
1544 - if (!isset($transaction[$field])){
1545 - $raw_data[$field] = $this->getData_Raw($field);
1546 - }
 1543+ foreach ( $stomp_fields as $field ){
 1544+ $raw_data[$field] = $this->getData_Raw( $field );
15471545 }
15481546
1549 - $transaction = array_merge($transaction, $raw_data);
 1547+ $transaction = array_merge( $raw_data, $transaction );
15501548
15511549 try {
15521550 wfRunHooks( $hook, array( $transaction ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104539More changes for the 'limbo' queue functionality....khorn03:08, 29 November 2011

Status & tagging log