r104525 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104524‎ | r104525 | r104526 >
Date:00:57, 29 November 2011
Author:raindrift
Status:ok
Tags:
Comment:
spelling and comment fixes
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/iframeApi/mw.IFramePlayerApiClient.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/iframeApi/mw.IFramePlayerApiServer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/iframeApi/mw.IFramePlayerApiClient.js
@@ -51,7 +51,7 @@
5252 'addPlayerReciveApi': function(){
5353 var _this = this;
5454 $.receiveMessage( function( event ){
55 - _this.hanldeReciveMsg( event );
 55+ _this.handleReciveMsg( event );
5656 }, this.iframeServer);
5757 },
5858 'addIframeFullscreenBinding': function(){
@@ -108,7 +108,7 @@
109109 /**
110110 * Handle received events
111111 */
112 - 'hanldeReciveMsg': function( event ){
 112+ 'handleReciveMsg': function( event ){
113113 var _this = this;
114114
115115 // Decode the message
@@ -181,7 +181,7 @@
182182 var playerProxy = $( '#' + originalIframeId ).get(0);
183183 var iframe = $('#' + iframePlayerId).get(0);
184184 if(!iframe){
185 - mw.log("Error invalide iFramePlayer request");
 185+ mw.log("Error invalid iFramePlayer request");
186186 return false;
187187 }
188188 if( !iframe['playerApi'] ){
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/iframeApi/mw.IFramePlayerApiServer.js
@@ -67,7 +67,7 @@
6868 var _this = this;
6969 mw.log('IFramePlayerApiServer::_addIframeListener');
7070 $.receiveMessage( function( event ) {
71 - _this.hanldeMsg( event );
 71+ _this.handleMsg( event );
7272 }, this.getParentUrl() );
7373 },
7474 getParentUrl: function(){
@@ -154,8 +154,8 @@
155155 *
156156 * @param {string} event
157157 */
158 - 'hanldeMsg': function( event ){
159 - mw.log( 'IFramePlayerApiServer:: hanldeMsg: ' + event.data );
 158+ 'handleMsg': function( event ){
 159+ mw.log( 'IFramePlayerApiServer:: handleMsg: ' + event.data );
160160 // Check if the server should even be enabled
161161 if( !mw.getConfig( 'EmbedPlayer.EnableIframeApi' )){
162162 mw.log( 'Error: Loading iFrame playerApi but config EmbedPlayer.EnableIframeApi is false');

Status & tagging log