r104523 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104522‎ | r104523 | r104524 >
Date:00:50, 29 November 2011
Author:dale
Status:ok
Tags:
Comment:
append div to targetContainer ( don't overuse $target )
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -1697,14 +1697,14 @@
16981698 * Shows the download interface with sources loaded
16991699 * @param {Object} $target jQuery target to output to
17001700 */
1701 - showDownloadWithSources : function( $target ) {
 1701+ showDownloadWithSources : function( $targetContainer ) {
17021702 var _this = this;
1703 - mw.log( 'showDownloadWithSources::' + $target.length );
 1703+ mw.log( 'showDownloadWithSources::' + $targetContainer.length );
17041704 var embedPlayer = this.embedPlayer;
17051705 // Empty the target:
1706 - $target.empty();
1707 - $target.append( $('<div />') );
1708 - $target = $target.find('div');
 1706+ $targetContainer.empty();
 1707+ $targetContainer.append( $('<div />') );
 1708+ $target = $targetContainer.find('div');
17091709
17101710 var $mediaList = $( '<ul />' );
17111711 var $textList = $( '<ul />' );

Status & tagging log