r104519 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104518‎ | r104519 | r104520 >
Date:00:28, 29 November 2011
Author:preilly
Status:ok
Tags:
Comment:
remove unneeded else condition
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -87,7 +87,7 @@
8888 }
8989
9090 class ExtMobileFrontend {
91 - const VERSION = '0.5.78';
 91+ const VERSION = '0.5.79';
9292
9393 /**
9494 * @var DOMDocument
@@ -129,8 +129,8 @@
130130 public static $hideSearchBox = false;
131131 public static $hideLogo = false;
132132 public static $languageUrls;
133 - public static $wsLoginToken;
134 - public static $wsLoginFormAction;
 133+ public static $wsLoginToken = '';
 134+ public static $wsLoginFormAction = '';
135135
136136 public static $messageKeys = array(
137137 'mobile-frontend-show-button',
@@ -416,9 +416,6 @@
417417 $returnToVal = $wgRequest->getVal( 'returnto' );
418418 $returnto = ( !empty ( $returnToVal ) ) ? '&returnto=' . wfUrlencode( $returnToVal ) : '';
419419 self::$wsLoginFormAction = self::$title->getLocalURL( 'action=submitlogin&type=login' . $returnto );
420 - } else {
421 - self::$wsLoginToken = '';
422 - self::$wsLoginFormAction = '';
423420 }
424421
425422 self::$htmlTitle = $out->getHTMLTitle();

Status & tagging log