r104516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104515‎ | r104516 | r104517 >
Date:00:09, 29 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Bit more documentation

(test commit also)
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -226,6 +226,8 @@
227227
228228 protected $preparedArgs;
229229
 230+ protected $htmlErrors;
 231+
230232 # ------------------------------------------------------------------------------
231233 # Accessors
232234 # ------------------------------------------------------------------------------
@@ -621,6 +623,11 @@
622624 * Same as new DatabaseMysql( ... ), kept for backward compatibility
623625 * @deprecated since 1.17
624626 *
 627+ * @param $server
 628+ * @param $user
 629+ * @param $password
 630+ * @param $dbName
 631+ * @param $flags int
625632 * @return DatabaseMysql
626633 */
627634 static function newFromParams( $server, $user, $password, $dbName, $flags = 0 ) {
@@ -692,6 +699,10 @@
693700 }
694701 }
695702
 703+ /**
 704+ * @param $errno
 705+ * @param $errstr
 706+ */
696707 protected function connectionErrorHandler( $errno, $errstr ) {
697708 $this->mPHPError = $errstr;
698709 }
@@ -1542,8 +1553,10 @@
15431554 }
15441555
15451556 /**
1546 - * @todo document
15471557 * mysql_field_type() wrapper
 1558+ * @param $res
 1559+ * @param $index
 1560+ * @return string
15481561 */
15491562 function fieldType( $res, $index ) {
15501563 if ( $res instanceof ResultWrapper ) {
@@ -2278,6 +2291,8 @@
22792292 * which index to pick. Anyway, other databases might have different
22802293 * indexes on a given table. So don't bother overriding this unless you're
22812294 * MySQL.
 2295+ * @param $index
 2296+ * @return string
22822297 */
22832298 function useIndexClause( $index ) {
22842299 return '';

Status & tagging log