r104496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104495‎ | r104496 | r104497 >
Date:21:58, 28 November 2011
Author:inez
Status:deferred
Tags:
Comment:
Put cursor directly in body element. This way it still can be positioned absolutly but without risk that some other element using position other than "static" (like #bodyContent) will change positioning context.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js
@@ -25,7 +25,7 @@
2626 this.$input = $( '<textarea class="es-surfaceView-textarea" />' )
2727 .prependTo( this.$ );
2828 this.$cursor = $( '<div class="es-surfaceView-cursor"></div>' )
29 - .appendTo( this.$ );
 29+ .appendTo( 'body' );
3030 this.updateSelectionTimeout = undefined;
3131 this.emitUpdateTimeoue = undefined;
3232

Status & tagging log