r104461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104460‎ | r104461 | r104462 >
Date:17:56, 28 November 2011
Author:danwe
Status:ok
Tags:
Comment:
some minor comments cleanup
Modified paths:
  • /trunk/extensions/Variables/Variables.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Variables/Variables.php
@@ -3,9 +3,6 @@
44 /**
55 * 'Variables' introduces parser functions for defining page-scoped variables within
66 * wiki pages.
7 - * Version 2.0 is a major re-write of the extension by Daniel Werner, as attempt to
8 - * get rid of any problems related to the fact that there are multiple Parser instances
9 - * for which 'Variables' extension should bring separate variable stores.
107 *
118 * Documentation: http://www.mediawiki.org/wiki/Extension:Variables
129 * Support: http://www.mediawiki.org/wiki/Extension_talk:Variables
@@ -22,7 +19,7 @@
2320 * @ingroup Variables
2421 */
2522
26 -if ( ! defined( 'MEDIAWIKI' ) ) { die( ); }
 23+if ( ! defined( 'MEDIAWIKI' ) ) { die(); }
2724
2825 $wgExtensionCredits['parserhook'][] = array(
2926 'path' => __FILE__,
@@ -251,9 +248,8 @@
252249 * MessageCaches Parser clone will mess things up if we don't reset the entire object.
253250 * Only resetting the array would unset it in the original object as well! This instead
254251 * will break the entire reference to the object
255 - */
 252+ */
256253 $parser->mExtVariables = new self();
257 -
258254 return true;
259255 }
260256
@@ -282,17 +278,17 @@
283279 #
284280 # public non-parser functions, accessible for
285281 # other extensions doing interactive stuff
286 - # with variables (like Extension:Loops)
 282+ # with 'Variables' (like Extension:Loops)
287283 #
288284
289285 /**
290 - * Convenience function to return the variables extensions variables store connected
 286+ * Convenience function to return the 'Variables' extensions variables store connected
291287 * to a certain Parser object. Each parser has its own store which will be reset after
292288 * a parsing process [Parser::parse()] has finished.
293289 *
294290 * @param Parser &$parser
295291 *
296 - * @return ExtVariables by reference so we still have the right objecdt after 'ParserClearState'
 292+ * @return ExtVariables by reference so we still have the right object after 'ParserClearState'
297293 */
298294 public static function &get( Parser &$parser ) {
299295 return $parser->mExtVariables;
@@ -358,6 +354,7 @@
359355 * @param Parser $parser
360356 * @param string $varName
361357 * @param string $defaultVal
 358+ *
362359 * @return string strip-item
363360 */
364361 function requestFinalizedVar( Parser &$parser, $varName, $defaultVal = '' ) {

Status & tagging log