r104447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104446‎ | r104447 | r104448 >
Date:15:45, 28 November 2011
Author:cervidae
Status:ok
Tags:
Comment:
Removing old folder 'SharedHelpNamespace'
Modified paths:
  • /trunk/extensions/HelpCommons/HelpCommons.php (modified) (history)
  • /trunk/extensions/SharedHelpNamespace (deleted) (history)

Diff [purge]

Index: trunk/extensions/HelpCommons/HelpCommons.php
@@ -92,7 +92,7 @@
9393 * @param $fields
9494 * @return bool
9595 */
96 -function wfHelpCommonsRedirectTalks( $article, $fields ) {
 96+function wfHelpCommonsRedirectTalks( &$article, &$outputDone, &$pcache ) {
9797 global $wgTitle, $wgOut, $wgContLang, $wgHelpCommonsFetchingWikis, $wgLanguageCode, $wgDBname;
9898
9999 if ( $wgTitle->getNamespace() != NS_HELP_TALK ) {
@@ -201,7 +201,6 @@
202202 global $wgHelpCommonsFetchingWikis, $wgDBname;
203203
204204 foreach ( $wgHelpCommonsFetchingWikis as $urls ) {
205 - // FIXME: don't use global esk variable names for non globals
206205 foreach ( $urls as $url => $helpwiki ) {
207206 // only protect Help pages on non-help-pages-fetching wikis
208207 if( $wgDBname != $helpwiki ) {

Status & tagging log