r104297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104296‎ | r104297 | r104298 >
Date:20:18, 26 November 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Bug 32662 - apc.css should be loaded with ResourceLoader

Patch by Lewis Cawte
Modified paths:
  • /trunk/extensions/APC/APC.php (modified) (history)
  • /trunk/extensions/APC/SpecialAPC.php (modified) (history)

Diff [purge]

Index: trunk/extensions/APC/APC.php
@@ -32,3 +32,9 @@
3333 $wgSpecialPageGroups['APC'] = 'wiki';
3434
3535 $wgAvailableRights[] = 'apc';
 36+
 37+$wgResourceModules['ext.apc'] = array(
 38+ 'styles' => 'apc.css',
 39+ 'localBasePath' => dirname(__FILE__),
 40+ 'remoteExtPath' => 'APC'
 41+);
Index: trunk/extensions/APC/SpecialAPC.php
@@ -100,9 +100,7 @@
101101 }
102102 }
103103
104 - $wgOut->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css',
105 - 'href' => "$wgScriptPath/extensions/APC/apc.css?$wgStyleVersion", )
106 - );
 104+ $wgOut->addModuleStyles( 'ext.apc' );
107105
108106 $this->getLogo();
109107 $this->mainMenu();

Sign-offs

UserFlagDate
Lcawtetested21:56, 26 November 2011

Status & tagging log