r104215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104214‎ | r104215 | r104216 >
Date:02:08, 25 November 2011
Author:aaron
Status:ok
Tags:
Comment:
Fixed doFlaggedRevsRevTimestamp() in updater, broken in r99755 and also had the wrong directory
Modified paths:
  • /trunk/extensions/FlaggedRevs/backend/schema/FlaggedRevsUpdater.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/backend/schema/FlaggedRevsUpdater.hooks.php
@@ -90,14 +90,17 @@
9191 $du->output( "...fr_rev_timestamp already exists.\n" );
9292 return;
9393 }
94 - include_once( dirname( __FILE__ ) . "/../maintenance/populateRevTimestamp.inc" );
95 - if ( !function_exists( 'populate_fr_rev_timestamp' ) ) {
96 - $du->output( "...populateRevTimestamp.inc missing! Aborting fr_rev_timestamp update.\n" );
97 - return; // sanity
 94+ $scriptDir = dirname( __FILE__ ) . "/../../maintenance/populateRevTimestamp.php";
 95+ if ( !file_exists( $scriptDir ) ) {
 96+ $du->output( "...populateRevTimestamp.php missing! Aborting fr_rev_timestamp update.\n" );
 97+ return; // sanity; all or nothing
9898 }
9999 $du->output( "Adding fr_rev_timestamp and redoing flaggedrevs table indexes... " );
 100+ // Change the schema
100101 $du->getDB()->sourceFile( $patch );
101 - populate_fr_rev_timestamp( 0 );
 102+ // Populate columns
 103+ $task = $du->maintenance->runChild( 'PopulateFRRevTimestamp', $scriptDir );
 104+ $task->execute();
102105 $du->output( "done.\n" );
103106 }
104107 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99755Converted some scripts to use the Maintenance classaaron06:53, 14 October 2011

Status & tagging log