r104177 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104176‎ | r104177 | r104178 >
Date:16:13, 24 November 2011
Author:catrope
Status:deferred
Tags:
Comment:
Fix the prepareContentAnnotation test cases added in r104102
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js
——@@ -1050,6 +1050,9 @@
10511051 if ( this.data[i].type !== undefined ) {
10521052 // Don't annotate structural elements
10531053 if ( on ) {
 1054+ if ( span ) {
 1055+ tx.pushRetain( span );
 1056+ }
10541057 tx.pushStopAnnotating( method, annotation );
10551058 span = 0;
10561059 on = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104102Added test that exposes bugs in prepareContentAnnotationtparscal23:24, 23 November 2011

Status & tagging log