r10416 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r10415‎ | r10416 | r10417 >
Date:10:32, 9 August 2005
Author:hashar
Status:old
Tags:
Comment:
limitResult use 3 parameters since ORACLE changes
Modified paths:
  • /trunk/phase3/maintenance/convertLinks.inc (modified) (history)
  • /trunk/phase3/maintenance/rebuildrecentchanges.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildrecentchanges.inc
@@ -49,7 +49,8 @@
5050 $dbw->query( $sql );
5151
5252 $sql = "SELECT rc_timestamp FROM $recentchanges " .
53 - "ORDER BY rc_timestamp DESC" . $dbw->limitResult( 1, 5000 );
 53+ "ORDER BY rc_timestamp DESC";
 54+ $sql = $dbw->limitResult($sql, 1, 5000 );
5455 $res = $dbw->query( $sql );
5556 $obj = $dbw->fetchObject( $res );
5657 if( $obj ) {
Index: trunk/phase3/maintenance/convertLinks.inc
@@ -102,7 +102,8 @@
103103 performanceLog( "rows inserted vs seconds elapsed:\n" );
104104
105105 for ($rowOffset = $initialRowOffset; $rowOffset < $numRows; $rowOffset += $linksConvInsertInterval) {
106 - $sqlRead = "SELECT * FROM $links ".$dbw->limitResult($linksConvInsertInterval,$rowOffset);
 106+ $sqlRead = "SELECT * FROM $links ";
 107+ $sqlRead = $dbw->limitResult($sqlRead, $linksConvInsertInterval,$rowOffset);
107108 $res = $dbw->query($sqlRead);
108109 if ( $noKeys ) {
109110 $sqlWrite = array("INSERT INTO $links_temp (l_from,l_to) VALUES ");

Status & tagging log