r104145 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r104144
|
r104145
|
r104146
>
Date:
09:41, 24 November 2011
Author:
hashar
Status:
ok
Tags:
Comment:
revert
r102636
This move back the maintenance finalSetup code above core Setup.
If we really need to do any setup after core Setup has run, we should use
a new method in the Maintenance class. For example afterCoreSetup()
Modified paths:
/trunk/phase3/maintenance/doMaintenance.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/maintenance/doMaintenance.php
—
—
@@ -93,11 +93,10 @@
94
94
{
95
95
require( MWInit::interpretedPath( 'AdminSettings.php' ) );
96
96
}
97
+$maintenance->finalSetup();
97
98
// Some last includes
98
99
require_once( MWInit::compiledPath( 'includes/Setup.php' ) );
99
100
100
-$maintenance->finalSetup();
101
-
102
101
// Much much faster startup than creating a title object
103
102
$wgTitle = null;
104
103
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r102636
load up includes/Setup.php before Maintenance::finalSetup()...
hashar
11:18, 10 November 2011
Status & tagging log
18:23, 25 November 2011
Platonides
(
talk
|
contribs
)
changed the
status
of r104145
[
removed:
new
added:
ok]