r104119 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104118‎ | r104119 | r104120 >
Date:00:42, 24 November 2011
Author:rmoen
Status:ok
Tags:
Comment:
replaced use of html() to text() where needed, follow up to r103943
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -256,10 +256,10 @@
257257 function confirmAction(params, $item){
258258
259259 var inlineForm = $('<span>').attr('class', 'fbd-item-reason')
260 - .append( $('<span>').html(mw.msg( 'moodbar-action-reason' )) )
 260+ .append( $('<span>').text(mw.msg( 'moodbar-action-reason' )) )
261261 .append( $('<input />').attr({'class':'fbd-action-reason', 'name':'fbd-action-reason'}) )
262 - .append( $('<button>').attr('class', 'fbd-action-confirm').html( mw.msg('moodbar-feedback-action-confirm')) )
263 - .append( $('<button>').attr('class', 'fbd-action-cancel').html( mw.msg('moodbar-feedback-action-cancel')) )
 262+ .append( $('<button>').attr('class', 'fbd-action-confirm').text( mw.msg('moodbar-feedback-action-confirm')) )
 263+ .append( $('<button>').attr('class', 'fbd-action-cancel').text( mw.msg('moodbar-feedback-action-cancel')) )
264264 .append( $('<span>').attr('class', 'fbd-item-reason-msg') )
265265 .append( $('<div>').attr('class', 'fbd-item-reason-msg') );
266266
@@ -412,16 +412,16 @@
413413 //build form
414414 var inlineForm = $('<div>').attr( 'class', 'fbd-response-form' )
415415 .append(
416 - $('<b>').html( mw.msg( 'moodbar-response-add' ) )
 416+ $('<b>').text( mw.msg( 'moodbar-response-add' ) )
417417 ).append(
418 - $('<small>').attr( 'class', 'fbd-text-gray' ).html( ' (' + mw.msg( 'moodbar-response-nosig' ) + ') ' )
 418+ $('<small>').attr( 'class', 'fbd-text-gray' ).text( ' (' + mw.msg( 'moodbar-response-nosig' ) + ') ' )
419419 ).append(
420420 $('<div>').attr( 'class', 'fbd-response-formNote' )
421421 .append($('<small>')
422422 .append(
423423 $('<span>').attr( 'class', 'fbd-response-charCount' )
424424 ).append(
425 - $('<span>').html( mw.msg( 'moodbar-form-note-dynamic' ).replace( /\$1/g, "" ) )
 425+ $('<span>').text( mw.msg( 'moodbar-form-note-dynamic' ).replace( /\$1/g, "" ) )
426426 )
427427 )
428428 ).append(
@@ -429,7 +429,7 @@
430430 ).append(
431431 $('<div>').attr('class', 'ula').html( ula )
432432 ).append(
433 - $('<button>').attr( 'class', 'fbd-response-submit' ).html( mw.msg( 'moodbar-response-btn' ) + ' ' + mw.msg( 'moodbar-respond-collapsed' ) )
 433+ $('<button>').attr( 'class', 'fbd-response-submit' ).text( mw.msg( 'moodbar-response-btn' ) + ' ' + mw.msg( 'moodbar-respond-collapsed' ) )
434434 .attr({'disabled':'true'})
435435 ).append(
436436 $('<div>').attr( 'style', 'clear:both' )
@@ -524,7 +524,7 @@
525525 */
526526 function inlineMessage( $el, msg, callback) {
527527 $el.empty()
528 - .html( msg )
 528+ .text( msg )
529529 .delay(2000)
530530 .fadeOut('slow', callback);
531531 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103943Phase 2. Feedback Response front end and Dashboard ie fixes.rmoen19:28, 22 November 2011

Status & tagging log