r104113 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104112‎ | r104113 | r104114 >
Date:00:01, 24 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
No need to fallback to zero, delay must be non-zero for the setTimeout to be run
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js
@@ -155,7 +155,7 @@
156156 _this.documentView.clearSelection( _this.currentSelection );
157157 }
158158 _this.updateSelectionTimeout = undefined;
159 - }, delay || 0 );
 159+ }, delay );
160160 } else {
161161 if ( this.currentSelection.from !== this.currentSelection.to ) {
162162 this.hideCursor();
@@ -176,7 +176,7 @@
177177 this.emitUpdateTimeout = setTimeout( function() {
178178 _this.emit( 'update' );
179179 _this.emitUpdateTimeout = undefined;
180 - }, delay || 0 );
 180+ }, delay );
181181 } else {
182182 this.emit( 'update' );
183183 }

Status & tagging log