r104105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104104‎ | r104105 | r104106 >
Date:23:39, 23 November 2011
Author:ashley
Status:ok
Tags:
Comment:
SocialProfile: partial revert of r102176, r102180 and r102288 -- UserProfile's UserProfilePage.php accesses these properties, so they can't be private
Modified paths:
  • /trunk/extensions/SocialProfile/SystemGifts/UserSystemGiftsClass.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserGifts/UserGiftsClass.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserRelationship/UserRelationshipClass.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserRelationship/UserRelationshipClass.php
@@ -3,8 +3,8 @@
44 * Functions for managing relationship data
55 */
66 class UserRelationship {
7 - private $user_id;
8 - private $user_name;
 7+ public $user_id;
 8+ public $user_name;
99
1010 /**
1111 * Constructor
Index: trunk/extensions/SocialProfile/UserGifts/UserGiftsClass.php
@@ -5,8 +5,8 @@
66 */
77 class UserGifts {
88
9 - private $user_id; # Text form (spaces not underscores) of the main part
10 - private $user_name; # Text form (spaces not underscores) of the main part
 9+ public $user_id; # Text form (spaces not underscores) of the main part
 10+ public $user_name; # Text form (spaces not underscores) of the main part
1111
1212 /**
1313 * Constructor
Index: trunk/extensions/SocialProfile/SystemGifts/UserSystemGiftsClass.php
@@ -4,8 +4,8 @@
55 */
66 class UserSystemGifts {
77
8 - private $user_id; # Text form (spaces not underscores) of the main part
9 - private $user_name; # Text form (spaces not underscores) of the main part
 8+ public $user_id; # Text form (spaces not underscores) of the main part
 9+ public $user_name; # Text form (spaces not underscores) of the main part
1010
1111 /**
1212 * Constructor

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102176SocialProfile: as per Markus' in-depth review:...ashley14:55, 6 November 2011
r102180SocialProfile: as per Markus' in-depth review:...ashley15:11, 6 November 2011
r102288SocialProfile: as per Markus' in-depth review:...ashley15:12, 7 November 2011

Status & tagging log