r104046 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104045‎ | r104046 | r104047 >
Date:16:21, 23 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Kill some more mysql 4 related things from the installer

* (bug 32217) Drop MySQL 4 support
Modified paths:
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -213,22 +213,13 @@
214214 * @return array
215215 */
216216 public function getEngines() {
217 - $engines = array( 'InnoDB', 'MyISAM' );
218217 $status = $this->getConnection();
219 - if ( !$status->isOK() ) {
220 - return $engines;
221 - }
 218+
222219 /**
223220 * @var $conn DatabaseBase
224221 */
225222 $conn = $status->value;
226223
227 - $version = $conn->getServerVersion();
228 - if ( version_compare( $version, "4.1.2", "<" ) ) {
229 - // No SHOW ENGINES in this version
230 - return $engines;
231 - }
232 -
233224 $engines = array();
234225 $res = $conn->query( 'SHOW ENGINES', __METHOD__ );
235226 foreach ( $res as $row ) {
@@ -246,16 +237,7 @@
247238 * @return array
248239 */
249240 public function getCharsets() {
250 - $status = $this->getConnection();
251 - $mysql5 = array( 'binary', 'utf8' );
252 - $mysql4 = array( 'mysql4' );
253 - if ( !$status->isOK() ) {
254 - return $mysql5;
255 - }
256 - if ( version_compare( $status->value->getServerVersion(), '4.1.0', '>=' ) ) {
257 - return $mysql5;
258 - }
259 - return $mysql4;
 241+ return array( 'binary', 'utf8' );
260242 }
261243
262244 /**

Sign-offs

UserFlagDate
Nikerabbitinspected07:57, 24 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104045Kill $wgDBmysql4 from DefaultSettings.php, not used in phase3 or any extensio...reedy16:14, 23 November 2011

Status & tagging log