r103993 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103992‎ | r103993 | r103994 >
Date:00:48, 23 November 2011
Author:brion
Status:ok
Tags:
Comment:
Revert r103770 (bug 24037) -- added full-page size to Special:Contribs which doesn't seem to be what we want here?
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -712,12 +712,6 @@
713713 $mflag = '';
714714 }
715715
716 - if ( !is_null( $rev->getSize() ) && !$rev->isDeleted( Revision::DELETED_TEXT ) ) {
717 - $mSize = $this->getSkin()->formatRevisionSize( $rev->getSize() );
718 - } else {
719 - $mSize = '';
720 - }
721 -
722716 // Don't show useless link to people who cannot hide revisions
723717 $canHide = $user->isAllowed( 'deleterevision' );
724718 if( $canHide || ($rev->getVisibility() && $user->isAllowed('deletedhistory')) ) {
@@ -738,7 +732,7 @@
739733 }
740734
741735 $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
742 - $ret = "{$del}{$d} {$diffHistLinks}{$chardiff}{$nflag}{$mflag} {$link}{$userlink} {$mSize} {$comment} {$topmarktext}";
 736+ $ret = "{$del}{$d} {$diffHistLinks}{$chardiff}{$nflag}{$mflag} {$link}{$userlink} {$comment} {$topmarktext}";
743737
744738 # Denote if username is redacted for this edit
745739 if( $rev->isDeleted( Revision::DELETED_USER ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r112183release-notes-1.19...krinkle02:43, 23 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88008* bug 24037freakolowsky17:11, 13 May 2011
r103770(bug 24037) Add byte length of revision to Special:Contributions. Patch by Um...catrope18:17, 20 November 2011

Status & tagging log