r103961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103960‎ | r103961 | r103962 >
Date:21:44, 22 November 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 32582) Fix TOC show/hide link regression on IE 8

MFT part of r93364: $('<a href=blah>') doesn't work in IE 8 without closing tag (</a> at end or <a .../>). Trunk cleanup had already fixed this.
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/resources/mediawiki/mediawiki.util.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -15,6 +15,7 @@
1616 * (bug 32228) regression in Special:Search which did not conserve profile on new search
1717 * (bug 32460) Categories were improperly aligned in Simple and CologneBlue
1818 * (bug 32412) TOC links on [[Special:EditWatchlist]] points to the fieldsets
 19+* (bug 32582) Fix TOC show/hide link regression on IE 8
1920
2021 === Changes since 1.18 beta 1 ===
2122 * (bug 31886) Wrong titles redirecting to Special:Badtitle in the 1.18 deployment.
Index: branches/REL1_18/phase3/resources/mediawiki/mediawiki.util.js
@@ -86,13 +86,13 @@
8787 // Only add it if there is a TOC and there is no toggle added already
8888 if ( $tocContainer.size() && $tocTitle.size() && !$tocToggleLink.size() ) {
8989 var hideTocCookie = $.cookie( 'mw_hidetoc' );
90 - $tocToggleLink = $( '<a href="#" class="internal" id="togglelink">' )
 90+ $tocToggleLink = $( '<a href="#" class="internal" id="togglelink"></a>' )
9191 .text( mw.msg( 'hidetoc' ) )
9292 .click( function(e){
9393 e.preventDefault();
9494 util.toggleToc( $(this) );
9595 } );
96 - $tocTitle.append( $tocToggleLink.wrap( '<span class="toctoggle">' ).parent().prepend( '&nbsp;[' ).append( ']&nbsp;' ) );
 96+ $tocTitle.append( $tocToggleLink.wrap( '<span class="toctoggle"></span>' ).parent().prepend( '&nbsp;[' ).append( ']&nbsp;' ) );
9797
9898 if ( hideTocCookie == '1' ) {
9999 // Cookie says user want toc hidden

Follow-up revisions

RevisionCommit summaryAuthorDate
r103962* (bug 32582) Fix TOC show/hide link regression on IE 8...brion21:46, 22 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93364Applying code conventions:...krinkle05:53, 28 July 2011

Status & tagging log