r103955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103954‎ | r103955 | r103956 >
Date:20:40, 22 November 2011
Author:jeroendedauw
Status:reverted
Tags:
Comment:
added some messages
Modified paths:
  • /trunk/extensions/Reviews/Reviews.i18n.php (modified) (history)
  • /trunk/extensions/Reviews/specials/SpecialMyReviews.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Reviews/specials/SpecialMyReviews.php
@@ -54,24 +54,20 @@
5555 return false;
5656 }
5757
58 - if ( $this->getRequest()->wasPosted() ) {
59 -
 58+ if ( $subPage === '' ) {
 59+ $this->getOutput()->addWikiMsg( 'reviews-myreviews-header' );
 60+ $this->displayReviewList();
6061 }
6162 else {
62 - if ( $subPage === '' ) {
63 - $this->getOutput()->addWikiMsg( 'reviews-myreviews-header' );
 63+ $review = Review::selectRow( null, array( 'id' => $subPage, 'user_id' => $this->getUser()->getId() ) );
 64+
 65+ if ( $review == false ) {
 66+ $this->getOutput()->addWikiMsg( 'reviews-myreviews-nosuchreview' );
6467 $this->displayReviewList();
6568 }
6669 else {
67 - $review = Review::selectRow( null, array( 'id' => $subPage, 'user_id' => $this->getUser()->getId() ) );
68 -
69 - if ( $review == false ) {
70 - $this->getOutput()->addWikiMsg( 'reviews-myreviews-nosuchreview' );
71 - $this->displayReviewList();
72 - }
73 - else {
74 - $this->displayEditControl( $review );
75 - }
 70+ $this->getOutput()->addWikiMsg( 'reviews-myreviews-editheader' );
 71+ $this->displayEditControl( $review );
7672 }
7773 }
7874 }
Index: trunk/extensions/Reviews/Reviews.i18n.php
@@ -61,10 +61,12 @@
6262 // Special:MyReviews
6363 'reviews-myreviews-header' => 'This page lists all reviews you posted.',
6464 'reviews-myreviews-nosuchreview' => 'You do not have a review with the provided ID, it might have been deleted. All your reviews are listed below.',
 65+ 'reviews-myreviews-editheader' => 'On this page you can edit your review. You can also view a list of [[Special:MyReviews|reviews you posted]].',
6566
6667 // Special:Reviews
6768
6869 // Review pager
 70+ 'reviews-pager-no-results' => 'There are no reviews to list.',
6971 'reviews-pager-post-time' => 'Post time',
7072 'reviews-pager-state' => 'State',
7173 'reviews-pager-title' => 'Title',
@@ -90,6 +92,7 @@
9193 'reviews-submission-saving' => 'Submission button text while a save action is happening and the button gets disabled',
9294
9395 'reviews-myreviews-header' => "Line on top of a page explaining it's function",
 96+ 'reviews-myreviews-editheader' => '',
9497
9598 'reviews-pager-post-time' => 'Tabele column header',
9699 'reviews-pager-state' => 'Tabele column header',

Status & tagging log