r103939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103938‎ | r103939 | r103940 >
Date:18:55, 22 November 2011
Author:bsitu
Status:ok
Tags:
Comment:
followup to r103881 - add message documentation and change function visibility for setFeedbackItem
Modified paths:
  • /trunk/extensions/MoodBar/FeedbackResponseItem.php (modified) (history)
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -290,6 +290,9 @@
291291 'moodbar-type-happy' => '$1 is the username that can be used for GENDER',
292292 'moodbar-type-sad' => '$1 is the username that can be used for GENDER',
293293 'moodbar-type-confused' => '$1 is the username that can be used for GENDER',
 294+ 'moodbar-feedback-load-record-error' => 'Error message for errors in loading a feedback or response to a feedback',
 295+ 'moodbar-feedback-response-title' => 'The title for appending feedback response text to a user talk page',
 296+ 'moodbar-feedback-view-link' => 'link to an individual feedback',
294297 'moodbar-user-ip' => '{{Identical|IP Address}}',
295298 );
296299
Index: trunk/extensions/MoodBar/FeedbackResponseItem.php
@@ -263,11 +263,11 @@
264264 }
265265
266266 /**
267 - * Get the Feedback Item this Response is associated to
 267+ * Set the Feedback Item this Response is associated to
268268 * @param $mbf_id mbfr_mbf_id in moodbar_feedback_response table
269269 * @return bool
270270 */
271 - public function setFeedbackItem($mbf_id) {
 271+ protected function setFeedbackItem($mbf_id) {
272272 $dbr = wfGetDB( DB_SLAVE );
273273
274274 $row = $dbr->selectRow( 'moodbar_feedback', '*',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103827Add empty comment validation for new feedback data and add error catching for...bsitu19:30, 21 November 2011
r103881MoodBar Phase 2 - Feedback response APIbsitu01:45, 22 November 2011

Status & tagging log