r103919 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103918‎ | r103919 | r103920 >
Date:16:30, 22 November 2011
Author:reedy
Status:ok
Tags:
Comment:
A few more ok -> done
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -453,7 +453,7 @@
454454 } else {
455455 $this->output( "Adding $index key to table $table... " );
456456 $this->applyPatch( $patch, $fullpath );
457 - $this->output( "ok\n" );
 457+ $this->output( "done.\n" );
458458 }
459459 }
460460
@@ -469,7 +469,7 @@
470470 if ( $this->db->fieldExists( $table, $field, __METHOD__ ) ) {
471471 $this->output( "Table $table contains $field field. Dropping... " );
472472 $this->applyPatch( $patch, $fullpath );
473 - $this->output( "ok\n" );
 473+ $this->output( "done.\n" );
474474 } else {
475475 $this->output( "...$table table does not contain $field field.\n" );
476476 }
@@ -487,7 +487,7 @@
488488 if ( $this->db->indexExists( $table, $index, __METHOD__ ) ) {
489489 $this->output( "Dropping $index key from table $table... " );
490490 $this->applyPatch( $patch, $fullpath );
491 - $this->output( "ok\n" );
 491+ $this->output( "done.\n" );
492492 } else {
493493 $this->output( "...$index key doesn't exist.\n" );
494494 }
@@ -502,7 +502,7 @@
503503 if ( $this->db->tableExists( $table, __METHOD__ ) ) {
504504 $this->output( "Dropping table $table... " );
505505 $this->applyPatch( $patch, $fullpath );
506 - $this->output( "ok\n" );
 506+ $this->output( "done.\n" );
507507 } else {
508508 $this->output( "...$table doesn't exist.\n" );
509509 }
@@ -528,7 +528,7 @@
529529 $this->output( "Modifying $field field of table $table..." );
530530 $this->applyPatch( $patch, $fullpath );
531531 $this->insertUpdateRow( $updateKey );
532 - $this->output( "ok\n" );
 532+ $this->output( "done.\n" );
533533 }
534534 }
535535
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -563,11 +563,11 @@
564564 $newug = $this->db->tableName( 'user_groups_bogus' );
565565 $this->output( "user_groups table exists but is in bogus intermediate format. Renaming to $newug... " );
566566 $this->db->query( "ALTER TABLE $oldug RENAME TO $newug", __METHOD__ );
567 - $this->output( "ok\n" );
 567+ $this->output( "done.\n" );
568568
569569 $this->output( "Re-adding fresh user_groups table... " );
570570 $this->applyPatch( 'patch-user_groups.sql' );
571 - $this->output( "ok\n" );
 571+ $this->output( "done.\n" );
572572
573573 $this->output( "***\n" );
574574 $this->output( "*** WARNING: You will need to manually fix up user permissions in the user_groups\n" );
@@ -587,7 +587,7 @@
588588 if ( $this->db->fieldExists( 'user', 'user_rights', __METHOD__ ) ) {
589589 $this->output( "Upgrading from a 1.3 or older database? Breaking out user_rights for conversion..." );
590590 $this->db->applyPatch( 'patch-user_rights.sql' );
591 - $this->output( done.\n" );
 591+ $this->output( "done.\n" );
592592 } else {
593593 $this->output( "*** WARNING: couldn't locate user_rights table or field for upgrade.\n" );
594594 $this->output( "*** You may need to manually configure some sysops by manipulating\n" );

Status & tagging log