r103879 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103878‎ | r103879 | r103880 >
Date:01:25, 22 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Reverted an issue in r103873 - fall through was intentional
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js
@@ -348,9 +348,9 @@
349349 this.handleEnter();
350350 e.preventDefault();
351351 break;
 352+ /*
352353 case 90: // z (undo/redo)
353354 if ( e.metaKey || e.ctrlKey ) {
354 - /*
355355 if ( this.keyboard.keys.shift ) {
356356 this.history.redo();
357357 } else {
@@ -361,9 +361,10 @@
362362 this.selection = selection.clone();
363363 this.showCursor();
364364 }
365 - */
 365+ break;
366366 }
367 - break;
 367+ // Fall through to default so the z key still otherwise works
 368+ */
368369 default: // Insert content (maybe)
369370 if ( this.keyboard.keydownTimeout ) {
370371 clearTimeout( this.keyboard.keydownTimeout );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103873Fixed breaks in a switch being inside ifs, causing them not to properly termi...tparscal23:53, 21 November 2011

Status & tagging log