r103870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103869‎ | r103870 | r103871 >
Date:23:42, 21 November 2011
Author:neilk
Status:ok
Tags:
Comment:
followup r103560 -- hopefully this is the logic wanted: if neither mediaSrc nor mwEmbedPath are local...
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js
@@ -73,10 +73,7 @@
7474 var mediaSrc = this.getSrc();
7575 var appletLoc = false;
7676 if (
77 - !( mw.isLocalDomain( mediaSrc )
78 - ||
79 - mw.isLocalDomain( mw.getMwEmbedPath() )
80 - )
 77+ !( mw.isLocalDomain( mediaSrc ) && mw.isLocalDomain( mw.getMwEmbedPath() ) )
8178 ){
8279 if ( window.cortadoDomainLocations[ new mw.Uri( mediaSrc ).host ] ) {
8380 appletLoc = window.cortadoDomainLocations[ new mw.Uri( mediaSrc ).host ];
@@ -208,4 +205,4 @@
209206 }
210207 };
211208
212 -} )( window.mediaWiki, window.jQuery );
\ No newline at end of file
 209+} )( window.mediaWiki, window.jQuery );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103560removed iframe ref in java getPlayerElementdale02:14, 18 November 2011

Status & tagging log