r103839 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103838‎ | r103839 | r103840 >
Date:21:33, 21 November 2011
Author:khorn
Status:ok
Tags:
Comment:
Changes stageData to a protected function, to help prevent things like double-staging data.
(This has the potential to result in things like multiplying our amount by an extra hundred, which would be Bad.)
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -1520,7 +1520,7 @@
15211521 * @param type $type Whatever types of staging you feel like having in your child class.
15221522 * ...but usually request and response. I think.
15231523 */
1524 - public function stageData( $type = 'request' ) {
 1524+ protected function stageData( $type = 'request' ) {
15251525 $this->defineStagedVars();
15261526 $this->smooshVarsForStaging(); //yup, we do need to do this seperately.
15271527 //If we tried to piggyback off the same loop, all the vars wouldn't be ready, and some staging functions will require

Follow-up revisions

RevisionCommit summaryAuthorDate
r103847MFT r102338, r102681, r102685, r102810, r102828, r102829, r102832, r102836, r...khorn22:30, 21 November 2011
r103848MFT r102338, r102681, r102685, r102810, r102828, r102829, r102832, r102836, r...khorn22:31, 21 November 2011

Status & tagging log