r103818 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103817‎ | r103818 | r103819 >
Date:16:20, 21 November 2011
Author:gregchiasson
Status:deferred
Tags:
Comment:
Per a comment on Prototype, the SpecialArticleFeedback class wasn't renamed in all places, which caused php warnings on the Special:SpecialPages list. Rename consistently, which should correct it.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/populateAFStatistics.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/populateAFStatistics.php
@@ -182,7 +182,7 @@
183183
184184 // populate stats table with problem articles & associated data
185185 // fetch stats type id - add stat type if it's non-existent
186 - $stats_type_id = SpecialArticleFeedback::getStatsTypeId( 'problems' );
 186+ $stats_type_id = SpecialArticleFeedbackv5::getStatsTypeId( 'problems' );
187187 if ( !$stats_type_id ) {
188188 $stats_type_id = $this->addStatType( 'problems' );
189189 }
@@ -235,7 +235,7 @@
236236 $this->output( "Caching latest problems (if cache present).\n" );
237237 // grab the article feedback special page so we can reuse the data structure building code
238238 // FIXME this logic should not be in the special page class
239 - $problems = SpecialArticleFeedback::buildProblems( $rowsCopy );
 239+ $problems = SpecialArticleFeedbackv5::buildProblems( $rowsCopy );
240240 // stash the data structure in the cache
241241 $key = wfMemcKey( 'article_feedback_stats_problems' );
242242 $wgMemc->set( $key, $problems, 86400 );
@@ -291,7 +291,7 @@
292292 $this->output( "Done\n" );
293293
294294 // fetch stats type id - add stat type if it's non-existant
295 - $stats_type_id = SpecialArticleFeedback::getStatsTypeId( 'highs_and_lows' );
 295+ $stats_type_id = SpecialArticleFeedbackv5::getStatsTypeId( 'highs_and_lows' );
296296 if ( !$stats_type_id ) {
297297 $stats_type_id = $this->addStatType( 'highs_and_lows' );
298298 }
@@ -335,7 +335,7 @@
336336 $key = wfMemcKey( 'article_feedback_stats_highs_lows' );
337337 // grab the article feedback special page so we can reuse the data structure building code
338338 // FIXME this logic should not be in the special page class
339 - $highs_lows = SpecialArticleFeedback::buildHighsAndLows( $rowsCopy );
 339+ $highs_lows = SpecialArticleFeedbackv5::buildHighsAndLows( $rowsCopy );
340340 // stash the data structure in the cache
341341 $wgMemc->set( $key, $highs_lows, 86400 );
342342 $this->output( "Done\n" );
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -6,7 +6,7 @@
77 * @ingroup Extensions
88 */
99
10 -class SpecialArticleFeedback extends SpecialPage {
 10+class SpecialArticleFeedbackv5 extends SpecialPage {
1111
1212 /* Methods */
1313

Status & tagging log