r103807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103806‎ | r103807 | r103808 >
Date:13:39, 21 November 2011
Author:petrb
Status:deferred
Tags:
Comment:
minor fixes
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php
@@ -185,13 +185,15 @@
186186 return true;
187187 }
188188
 189+ // get a status of user parsed from title
189190 $result = OnlineStatusBar::getUserInfoFromTitle( $parser->getTitle() );
190 - if ( User::isIP( $parser->getTitle()->getBaseText() ) && $result == null ) {
 191+ // if user is IP and we track them
 192+ if ( User::isIP( $parser->getTitle()->getBaseText() ) && $result === false ) {
191193 $result = OnlineStatusBar::getAnonFromTitle( $parser->getTitle() );
192194 }
193195
194 - if ( $result == false ) {
195 - $ret = "unknown";
 196+ if ( $result === false ) {
 197+ $ret = 'unknown';
196198 return true;
197199 }
198200

Status & tagging log