r103800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103799‎ | r103800 | r103801 >
Date:10:20, 21 November 2011
Author:petrb
Status:deferred
Tags:
Comment:
Improved support for styles
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarClassic.css (added) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarModern.css (added) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarNostalgia.css (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.php
@@ -38,12 +38,24 @@
3939 'remoteExtPath' => 'OnlineStatusBar',
4040 );
4141
 42+$wgResourceModules['ext.OnlineStatusBar.modern'] = array (
 43+ 'styles' => 'OnlineStatusBarModern.css',
 44+ 'localBasePath' => dirname ( __FILE__ ),
 45+ 'remoteExtPath' => 'OnlineStatusBar',
 46+);
 47+
4248 $wgResourceModules['ext.OnlineStatusBar.chick'] = array (
4349 'styles' => 'OnlineStatusBarChick.css',
4450 'localBasePath' => dirname ( __FILE__ ),
4551 'remoteExtPath' => 'OnlineStatusBar',
4652 );
4753
 54+$wgResourceModules['ext.OnlineStatusBar.standard'] = array (
 55+ 'styles' => 'OnlineStatusBarClassic.css',
 56+ 'localBasePath' => dirname ( __FILE__ ),
 57+ 'remoteExtPath' => 'OnlineStatusBar',
 58+);
 59+
4860 $wgResourceModules['ext.OnlineStatusBar.monobook'] = array (
4961 'styles' => 'OnlineStatusBarMono.css',
5062 'localBasePath' => dirname ( __FILE__ ),
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarClassic.css
@@ -0,0 +1,24 @@
 2+/*
 3+This is a part of css used on english wp, it's needed for wikis
 4+where topicon isn't defined
 5+*/
 6+div.onlinestatusbartop {
 7+ position: absolute;
 8+ top: 4em;
 9+ margin-right: 4px;
 10+ display: block !important;
 11+}
 12+
 13+div.onlinestatusbaricon {
 14+ border: 0px solid black;
 15+ background: transparent;
 16+ float: right;
 17+ position: relative;
 18+ top: 0px;
 19+ padding: 5px;
 20+}
 21+
 22+div.onlinestatusbarbody {
 23+ right:0px;
 24+ margin-top:6px;
 25+}
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarNostalgia.css
@@ -4,8 +4,8 @@
55 */
66 div.onlinestatusbartop {
77 position: absolute;
8 - top: ;
9 - margin-right: 2px;
 8+ top: 0px;
 9+ margin-right: 261px;
1010 display: block !important;
1111 }
1212
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php
@@ -138,6 +138,8 @@
139139 case 'monobook':
140140 case 'vector':
141141 case 'simple':
 142+ case 'modern':
 143+ case 'standard':
142144 case 'nostalgia':
143145 case 'chick':
144146 case 'cologneblue':
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarModern.css
@@ -0,0 +1,25 @@
 2+/*
 3+This is a part of css used on english wp, it's needed for wikis
 4+where topicon isn't defined
 5+*/
 6+div.onlinestatusbartop {
 7+ position: absolute;
 8+ top: 0px;
 9+ margin-right: 2px;
 10+ color: white;
 11+ display: block !important;
 12+}
 13+
 14+div.onlinestatusbaricon {
 15+ border: 0px solid black;
 16+ background: transparent;
 17+ float: right;
 18+ position: relative;
 19+ top: 0px;
 20+ padding: 5px;
 21+}
 22+
 23+div.onlinestatusbarbody {
 24+ right:0px;
 25+ margin-top:-3px;
 26+}

Status & tagging log