r103797 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103796‎ | r103797 | r103798 >
Date:09:22, 21 November 2011
Author:j
Status:deferred
Tags:
Comment:
Remove fallback for XiphQt in older version of Safari.
TMH requires a working <video> implementation elsewhere,
Safari versions without canPlaySupport also misse other
important features and did not work anyway.
Fixes #32475
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
@@ -145,10 +145,6 @@
146146 // Test for ogg
147147 if ( dummyvid.canPlayType( 'video/ogg; codecs="theora,vorbis"' ) ) {
148148 this.mediaPlayers.addPlayer( oggNativePlayer );
149 - // older versions of safari do not support canPlayType,
150 - // but xiph qt registers mimetype via quicktime plugin
151 - } else if ( this.supportedMimeType( 'video/ogg' ) ) {
152 - this.mediaPlayers.addPlayer( oggNativePlayer );
153149 }
154150 }
155151 } catch ( e ) {

Status & tagging log