r103788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103787‎ | r103788 | r103789 >
Date:21:38, 20 November 2011
Author:platonides
Status:ok
Tags:
Comment:
Move the hidden input with the title inside the <div> (adding a silly one for two-button search).
Removes dumb XHTML1 conformance warning about <input> (an inline element) not being able to be there
(a place for a block element). (Bug 13381)
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -424,7 +424,6 @@
425425 <div id="p-search">
426426 <h5<?php $this->html( 'userlangattributes' ) ?>><label for="searchInput"><?php $this->msg( 'search' ) ?></label></h5>
427427 <form action="<?php $this->text( 'wgScript' ) ?>" id="searchform">
428 - <input type='hidden' name="title" value="<?php $this->text( 'searchtitle' ) ?>"/>
429428 <?php if ( $wgVectorUseSimpleSearch && $this->getSkin()->getUser()->getOption( 'vector-simplesearch' ) ): ?>
430429 <div id="simpleSearch">
431430 <?php if ( $this->data['rtl'] ): ?>
@@ -434,12 +433,14 @@
435434 <?php if ( !$this->data['rtl'] ): ?>
436435 <?php echo $this->makeSearchButton( 'image', array( 'id' => 'searchButton', 'src' => $this->getSkin()->getSkinStylePath( 'images/search-ltr.png' ) ) ); ?>
437436 <?php endif; ?>
438 - </div>
439437 <?php else: ?>
440 - <?php echo $this->makeSearchInput( array( 'id' => 'searchInput' ) ); ?>
441 - <?php echo $this->makeSearchButton( 'go', array( 'id' => 'searchGoButton', 'class' => 'searchButton' ) ); ?>
442 - <?php echo $this->makeSearchButton( 'fulltext', array( 'id' => 'mw-searchButton', 'class' => 'searchButton' ) ); ?>
 438+ <div>
 439+ <?php echo $this->makeSearchInput( array( 'id' => 'searchInput' ) ); ?>
 440+ <?php echo $this->makeSearchButton( 'go', array( 'id' => 'searchGoButton', 'class' => 'searchButton' ) ); ?>
 441+ <?php echo $this->makeSearchButton( 'fulltext', array( 'id' => 'mw-searchButton', 'class' => 'searchButton' ) ); ?>
443442 <?php endif; ?>
 443+ <input type='hidden' name="title" value="<?php $this->text( 'searchtitle' ) ?>"/>
 444+ </div>
444445 </form>
445446 </div>
446447 <?php

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103773Change <br clear="all/left" to <br style="clear: in inline html....platonides18:57, 20 November 2011

Status & tagging log