r103781 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103780‎ | r103781 | r103782 >
Date:20:51, 20 November 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r103780: use other_args('uploadable') instead of other_args('is_uploadable')
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextWithAutocompleteInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextInput.php
@@ -166,7 +166,7 @@
167167 }
168168 $text = Xml::element( 'input', $inputAttrs );
169169
170 - if ( array_key_exists( 'is_uploadable', $other_args ) && $other_args['is_uploadable'] == true ) {
 170+ if ( array_key_exists( 'uploadable', $other_args ) && $other_args['uploadable'] == true ) {
171171 if ( array_key_exists( 'is_list', $other_args ) && $other_args['is_list'] == true ) {
172172 if ( array_key_exists( 'delimiter', $other_args ) ) {
173173 $delimiter = $other_args['delimiter'];
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php
@@ -133,7 +133,7 @@
134134 $textarea_input = Xml::element( 'textarea', $textarea_attrs, $cur_value, false );
135135 $text .= $textarea_input;
136136
137 - if ( array_key_exists( 'is_uploadable', $other_args ) && $other_args['is_uploadable'] == true ) {
 137+ if ( array_key_exists( 'uploadable', $other_args ) && $other_args['uploadable'] == true ) {
138138 if ( array_key_exists( 'default filename', $other_args ) ) {
139139 $default_filename = $other_args['default filename'];
140140 } else {
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextWithAutocompleteInput.php
@@ -178,7 +178,7 @@
179179 }
180180 $text = "\n\t" . Xml::element( 'input', $inputAttrs ) . "\n";
181181
182 - if ( array_key_exists( 'is_uploadable', $other_args ) && $other_args['is_uploadable'] == true ) {
 182+ if ( array_key_exists( 'uploadable', $other_args ) && $other_args['uploadable'] == true ) {
183183 if ( array_key_exists( 'default filename', $other_args ) ) {
184184 $default_filename = $other_args['default filename'];
185185 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103780make all field args available to input types (incl. mandatory, hidden, restri...foxtrott20:47, 20 November 2011