r103761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103760‎ | r103761 | r103762 >
Date:15:02, 20 November 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 32451) Clicking on a special characters section loses the selection in IE8. Patch by Lupo
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
@@ -438,13 +438,13 @@
439439 }
440440 },
441441 buildBookmark : function( context, id, page ) {
442 - var label = $.wikiEditor.autoMsg( page,
443 - 'label' );
 442+ var label = $.wikiEditor.autoMsg( page, 'label' );
444443 return $( '<div/>' )
445444 .text( label )
446445 .attr( 'rel', id )
447446 .data( 'context', context )
448447 .mousedown( function( e ) {
 448+ context.fn.saveCursorAndScrollTop();
449449 // No dragging!
450450 e.preventDefault();
451451 return false;
@@ -464,6 +464,7 @@
465465 if ( $.trackAction !== undefined){
466466 $.trackAction(section + '.' + $(this).attr('rel'));
467467 }
 468+ context.fn.restoreCursorAndScrollTop();
468469 // No dragging!
469470 event.preventDefault();
470471 return false;
@@ -488,7 +489,7 @@
489490 html += $.wikiEditor.modules.toolbar.fn.buildRow( context, page.rows[i] );
490491 }
491492 }
492 - $page.html( html );
 493+ $page.html( html + '</table>');
493494 break;
494495 case 'characters':
495496 $page.addClass( 'page-characters' );

Status & tagging log