r103746 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103745‎ | r103746 | r103747 >
Date:10:58, 20 November 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 32506) Inconsistent behavior for Special:EditWatchlist/raw when submitting an empty watchlist

Patch by Brad Jorsch
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEditWatchlist.php
@@ -152,7 +152,14 @@
153153 } else {
154154 $this->clearWatchlist();
155155 $this->getUser()->invalidateCache();
156 - $this->successMessage .= wfMessage(
 156+
 157+ if( count( $current ) > 0 ){
 158+ $this->successMessage = wfMessage( 'watchlistedit-raw-done' )->parse();
 159+ } else {
 160+ return false;
 161+ }
 162+
 163+ $this->successMessage .= ' ' . wfMessage(
157164 'watchlistedit-raw-removed',
158165 $this->getLang()->formatNum( count( $current ) )
159166 );

Status & tagging log