r103701 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103700‎ | r103701 | r103702 >
Date:19:01, 19 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r103692: don't add a query per row
Modified paths:
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialNewpages.php
@@ -297,7 +297,7 @@
298298 $lang = $this->getLang();
299299 $dm = $lang->getDirMark();
300300
301 - $title = Title::newFromID( $result->rc_cur_id );
 301+ $title = Title::newFromRow( $result );
302302 $spanTime = Html::element( 'span', array( 'class' => 'mw-newpages-time' ),
303303 $lang->timeanddate( $result->rc_timestamp, true )
304304 );
@@ -508,7 +508,8 @@
509509 $fields = array(
510510 'rc_namespace', 'rc_title', 'rc_cur_id', 'rc_user', 'rc_user_text',
511511 'rc_comment', 'rc_timestamp', 'rc_patrolled','rc_id', 'rc_deleted',
512 - 'page_len AS length', 'page_latest AS rev_id', 'ts_tags', 'rc_this_oldid'
 512+ 'page_len AS length', 'page_latest AS rev_id', 'ts_tags', 'rc_this_oldid',
 513+ 'page_namespace', 'page_title'
513514 );
514515 $join_conds = array( 'page' => array( 'INNER JOIN', 'page_id=rc_cur_id' ) );
515516

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103692(bug 30368) When a page is moved, link to and display the new name rather tha...catrope17:21, 19 November 2011

Status & tagging log