r103614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103613‎ | r103614 | r103615 >
Date:21:48, 18 November 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
changes for fabrice's request yesterday
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -473,6 +473,7 @@
474474 .articleFeedbackv5-panel .instructions-left {
475475 float:left;
476476 margin: 0 15px 0 0;
 477+ font-size: 1.2em;
477478 }
478479 .articleFeedbackv5-panel .buttons {
479480 float: left;
@@ -513,9 +514,13 @@
514515 height: 68px;
515516 overflow: hidden;
516517 padding: 10px;
517 - font-size: 14px;
 518+ font-size: 1.0em;
518519 font: sans-serif;
 520+ color: #ddd;
519521 }
 522+.articleFeedbackv5-panel .feedback-text.active {
 523+ color: #000;
 524+}
520525 .articleFeedbackv5-panel .articleFeedbackv5-disclosure {
521526 float: left;
522527 width: 335px;
@@ -523,6 +528,7 @@
524529 }
525530 .articleFeedbackv5-panel .articleFeedbackv5-disclosure p {
526531 margin: 0;
 532+ font-size: 0.75em;
527533 }
528534 .articleFeedbackv5-panel .articleFeedbackv5-submit {
529535 float: right;
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -139,7 +139,7 @@
140140 <div class="tooltip-repeat">\
141141 <h3><html:msg key="bucket1-tooltip-title" /></h3>\
142142 <p><html:msg key="bucket1-tooltip-info" /></p>\
143 - <p><a target="_blank" href="#"><html:msg key="bucket1-tooltip-linktext" /></a></p>\
 143+ <p><a target="_blank" href="http://www.mediawiki.org/wiki/Article_feedback/Version_5"><html:msg key="bucket1-tooltip-linktext" /></a></p>\
144144 </div>\
145145 <div class="tooltip-bottom"></div>\
146146 </div>\
@@ -252,7 +252,7 @@
253253
254254 // Clear out the question on focus
255255 $block.find( '.articleFeedbackv5-comment textarea' )
256 - .focus( function () {
 256+ .focus( function () {
257257 var def_msg = '';
258258 var val = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-bucket1-toggle input[checked]' ).val();
259259 if ( val == 'yes' ) {
@@ -263,7 +263,8 @@
264264 if ( $( this ).val() == def_msg ) {
265265 $( this ).val( '' );
266266 }
267 - } )
 267+ $(this).addClass(active);
 268+ })
268269 .blur( function () {
269270 var def_msg = '';
270271 var val = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-bucket1-toggle input[checked]' ).val();
@@ -274,8 +275,9 @@
275276 }
276277 if ( $( this ).val() == '' ) {
277278 $( this ).val( def_msg );
278 - }
 279+ }
279280 } );
 281+
280282
281283 // Attach the submit
282284 $block.find( '.articleFeedbackv5-submit' )

Status & tagging log