r103608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103607‎ | r103608 | r103609 >
Date:19:53, 18 November 2011
Author:jamesur
Status:ok
Tags:
Comment:
adjustments to bpay result output to add logos and legal language. Add finish button instead of link for results page on bank transfer
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -288,7 +288,7 @@
289289
290290 $url = $this->adapter->getThankYouPage() . $queryString;
291291
292 - $link = Xml::tags( 'a', array( 'href' => $url ), wfMsg( 'donate_interface-bt-finished' ) );
 292+ $link = HTML::input('MyButton', 'finished', 'button', array( 'onclick' => "window.location = '$url'" ) );
293293
294294 $return .= Xml::tags( 'p', array(), $link );
295295
@@ -334,14 +334,52 @@
335335
336336 $return .= Xml::closeElement( 'table' ); // close $id . '_table'
337337
 338+ $return .= Xml::openElement( 'table' ); //open info table
 339+
 340+ $return .= Xml::openElement( 'tr' );
 341+
 342+ $return .= Xml::openElement ( 'td', array( 'colspan' => '2' ) );
 343+
338344 $return .= Xml::tags( 'p', array(), wfMsg( 'donate_interface-online_bank_transfer_message' ) );
339345
 346+ $return .= Xml::closeElement ( 'td' );
 347+
 348+ $return .= Xml::closeElement ( 'tr' );
 349+
 350+ $return .= Xml::openElement ( 'tr' );
 351+
 352+ $return .= Xml::openElement( 'td' );
 353+
 354+ $return .= Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/gateway_forms/includes/BPAY_Landscape_MONO.gif", 'style' => 'vertical-align:center; width:100px; margin-right: 1em;' ) );
 355+
 356+ $return .= Xml::closeElement ( 'td' );
 357+
 358+ $return .= Xml::openElement ( 'td' );
 359+
 360+ $return .= Xml::tags( 'p', array(), 'Contact your bank or financial institution <br /> to make this payment from your cheque, <br /> debit, credit card or transaction account. <br /> More info: www.bpay.com.au ' );
 361+
 362+ $return .= Xml::closeElement ( 'td' );
 363+
 364+ $return .= Xml::closeElement ( 'tr' );
 365+
 366+ $return .= Xml::openElement ( 'tr' );
 367+
 368+ $return .= Xml::openElement ( 'td', array( 'colspan' => '2' ) );
 369+
 370+ $return .= Xml::tags( 'p', array(), '<br /> &reg; Registered to BPAY Pty Ltd ABN 69 079 137 518');
 371+
 372+ $return .= Xml::closeElement ( 'td' );
 373+
 374+ $return .= Xml::closeElement ( 'tr' );
 375+
 376+ $return .= Xml::closeElement ( 'table' ); //close info table
 377+
340378 $queryString = '?payment_method=' . $this->adapter->getPaymentMethod() . '&payment_submethod=' . $this->adapter->getPaymentSubmethod();
341379
342380 $url = $this->adapter->getThankYouPage() . $queryString;
 381+
 382+ $link = HTML::input('MyButton', 'finished', 'button', array( 'onclick' => "window.location = '$url'" ) );
343383
344 - $link = Xml::tags( 'a', array( 'href' => $url ), wfMsg( 'donate_interface-bt-finished' ) );
345 -
346384 $return .= Xml::tags( 'p', array(), $link );
347385
348386 $return .= Xml::closeElement( 'div' ); // $id

Follow-up revisions

RevisionCommit summaryAuthorDate
r103847MFT r102338, r102681, r102685, r102810, r102828, r102829, r102832, r102836, r...khorn22:30, 21 November 2011
r103848MFT r102338, r102681, r102685, r102810, r102828, r102829, r102832, r102836, r...khorn22:31, 21 November 2011

Status & tagging log