r103579 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103578‎ | r103579 | r103580 >
Date:07:10, 18 November 2011
Author:ialex
Status:ok
Tags:
Comment:
Fix for r103502: make PoolWorkArticleView::doWork() return true when the parse is successful; also fixed getIsDirty() to return the member parameter and not try to execute a non-existing function
Modified paths:
  • /trunk/phase3/includes/WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WikiPage.php
——@@ -2792,7 +2792,7 @@
27932793 * @return bool
27942794 */
27952795 public function getIsDirty() {
2796 - return $this->isDirty();
 2796+ return $this->isDirty;
27972797 }
27982798
27992799 /**
——@@ -2849,6 +2849,8 @@
28502850 if ( $isCurrent ) {
28512851 $this->page->doCascadeProtectionUpdates( $this->parserOutput );
28522852 }
 2853+
 2854+ return true;
28532855 }
28542856
28552857 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103502* Added WikiPage::getParserOutput() and changed Article::getParserOutput() to...ialex20:21, 17 November 2011

Status & tagging log