r103577 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103576‎ | r103577 | r103578 >
Date:06:45, 18 November 2011
Author:inez
Status:deferred
Tags:
Comment:
Temporary handle listitems merging/spliting logic in SurfaceView until it will be fixed in transaction preparation (prepareRemoval)
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js
——@@ -366,7 +366,7 @@
367367 sourceSplitableNode = es.DocumentViewNode.getSplitableNode( sourceNode ),
368368 targetSplitableNode = es.DocumentViewNode.getSplitableNode( targetNode );
369369
370 - if ( sourceNode === targetNode || ( sourceNode.model.getElementType() === targetNode.model.getElementType() && sourceSplitableNode.getParent() === targetSplitableNode.getParent() ) ) {
 370+ if ( sourceNode === targetNode /*|| ( sourceNode.model.getElementType() === targetNode.model.getElementType() && sourceSplitableNode.getParent() === targetSplitableNode.getParent() ) */) {
371371 var tx = this.documentView.model.prepareRemoval(
372372 new es.Range( targetOffset, sourceOffset )
373373 );

Status & tagging log