r103561 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103560‎ | r103561 | r103562 >
Date:02:18, 18 November 2011
Author:dale
Status:ok
Tags:
Comment:
wrap java pause request in an try catch
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js
@@ -199,7 +199,11 @@
200200 this.parent_pause();
201201 // Call the pause function if it exists:
202202 if ( this.playerElement ) {
203 - this.playerElement.pause();
 203+ try{
 204+ this.playerElement.pause();
 205+ }catch( e ){
 206+ mw.log("EmbedPlayerJava::Could not issue pause request");
 207+ }
204208 }
205209 }
206210 };

Status & tagging log