r103550 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103549‎ | r103550 | r103551 >
Date:00:56, 18 November 2011
Author:dale
Status:resolved (Comments)
Tags:
Comment:
added warning for calling applyMediaElementBindings without any player interface implementation
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -1225,8 +1225,16 @@
12261226 * Should be set via native embed support
12271227 */
12281228 applyMediaElementBindings: function(){
 1229+ mw.log("Warning /**
 1230+ * Should be set via native embed support
 1231+ */
 1232+ applyMediaElementBindings: function(){
 1233+ mw.log("Warning applyMediaElementBindings should be implemented by player interface" );
12291234 return ;
12301235 },
 1236+ should be implemented by player interface" );
 1237+ return ;
 1238+ },
12311239
12321240 /**
12331241 * Gets code to embed the player remotely for "share" this player links

Comments

#Comment by Raindrift (talk | contribs)   00:12, 19 November 2011

Between lines 1227 and 1237 this file is just plain broken. Looks like a copy/paste accident or something.

#Comment by Raindrift (talk | contribs)   00:16, 19 November 2011

Oh, looks like this is resolved in trunk. If I find the revision in question, I'll associate it as a followup.

Status & tagging log