r103545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103544‎ | r103545 | r103546 >
Date:00:47, 18 November 2011
Author:dale
Status:ok
Tags:
Comment:
more clear image swap
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -1091,9 +1091,11 @@
10921092 // mw.log('appended: new_img_thumb_');
10931093 $( '#new_img_thumb_' + this.id ).fadeIn( "slow", function() {
10941094 // once faded in remove org and rename new:
1095 - $( '#img_thumb_' + _this.id ).remove();
1096 - $( '#new_img_thumb_' + _this.id ).attr( 'id', 'img_thumb_' + _this.id );
1097 - $( '#img_thumb_' + _this.id ).css( 'z-index', '1' );
 1095+ $( '#img_thumb_' + _this.id )
 1096+ .replaceWith( $( '#new_img_thumb_' + _this.id ) )
 1097+ .attr( 'id', 'img_thumb_' + _this.id )
 1098+ .css( 'z-index', '1' );
 1099+
10981100 _this.thumbnailUpdatingFlag = false;
10991101
11001102 // if we have a thumb queued update to that

Status & tagging log