r103536 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103535‎ | r103536 | r103537 >
Date:00:27, 18 November 2011
Author:dale
Status:ok
Tags:
Comment:
renamed doneLoading property to playerReady
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.processEmbedPlayers.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -150,9 +150,9 @@
151151 'previewMode' : false,
152152
153153 // If the player is done loading ( does not guarantee playability )
154 - // for example if there is an error doneLoading is still set to true once
 154+ // for example if there is an error playerReady is still set to true once
155155 // no more loading is to be done
156 - 'doneLoading' : false,
 156+ 'playerReady' : false,
157157
158158 // Stores the loading errors
159159 'loadError' : false,
@@ -873,8 +873,8 @@
874874 // Update temporal url if present
875875 this.updateTemporalUrl();
876876
877 - // updat the doneLoading flag
878 - this.doneLoading = true;
 877+ // Update the playerReady flag
 878+ this.playerReady = true;
879879 // trigger the player ready event;
880880 $(this).trigger('playerReady');
881881
@@ -953,7 +953,7 @@
954954
955955 // TODO we should have a smart done Loading system that registers player states
956956 // http://www.whatwg.org/specs/web-apps/current-work/#media-element
957 - this.doneLoading = true;
 957+ this.playerReady = true;
958958 $(this).trigger('playerReady');
959959 },
960960
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.processEmbedPlayers.js
@@ -13,7 +13,7 @@
1414 var areSelectedPlayersReady = function(){
1515 var playersLoaded = true;
1616 $(playerSelect).each(function(inx, player){
17 - if( ! $( player ).get(0).doneLoading ){
 17+ if( ! $( player ).get(0).playerReady ){
1818 playersLoaded = false;
1919 return false;
2020 }

Status & tagging log