r103533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103532‎ | r103533 | r103534 >
Date:00:22, 18 November 2011
Author:dale
Status:ok
Tags:
Comment:
fixed spelling and naming of addWarningBinding method
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -937,7 +937,7 @@
938938 // Update the poster and html:
939939 this.updatePosterHTML();
940940 // Add the warning
941 - this.controlBuilder.doWarningBindinng( 'EmbedPlayer.DirectFileLinkWarning',
 941+ this.controlBuilder.addWarningBinding( 'EmbedPlayer.DirectFileLinkWarning',
942942 gM( 'mwe-embedplayer-download-warn', mw.getConfig('EmbedPlayer.FirefoxLink') )
943943 );
944944
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -494,7 +494,7 @@
495495 gM( 'mwe-embedplayer-fullscreen-tip-osx') :
496496 gM( 'mwe-embedplayer-fullscreen-tip');
497497
498 - var $targetTip = this.doWarningBindinng( 'EmbedPlayer.FullscreenTip',
 498+ var $targetTip = this.addWarningBinding( 'EmbedPlayer.FullscreenTip',
499499 $('<h3/>').html(
500500 toolTipMsg
501501 )
@@ -712,7 +712,7 @@
713713 }
714714 // Add recommend firefox if we have non-native playback:
715715 if ( _this.checkNativeWarning( ) ) {
716 - _this.doWarningBindinng( 'EmbedPlayer.ShowNativeWarning',
 716+ _this.addWarningBinding( 'EmbedPlayer.ShowNativeWarning',
717717 gM( 'mwe-embedplayer-for_best_experience', mw.getConfig('EmbedPlayer.FirefoxLink') )
718718 );
719719 }
@@ -924,8 +924,8 @@
925925 * @param {object} warningMsg The jQuery object warning message to be displayed.
926926 *
927927 */
928 - doWarningBindinng: function( preferenceId, warningMsg ) {
929 - mw.log( 'mw.PlayerControlBuilder:: doWarningBindinng: ' + preferenceId + ' wm: ' + warningMsg);
 928+ addWarningBinding: function( preferenceId, warningMsg ) {
 929+ mw.log( 'mw.PlayerControlBuilder:: addWarningBinding: ' + preferenceId + ' wm: ' + warningMsg);
930930 // Set up local pointer to the embedPlayer
931931 var embedPlayer = this.embedPlayer;
932932 var _this = this;

Status & tagging log