r103493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103492‎ | r103493 | r103494 >
Date:19:05, 17 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed the last of the rendering to much bugs - now things are rendered when needed only
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/bases/es.DocumentViewBranchNode.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/bases/es.DocumentViewBranchNode.js
@@ -55,7 +55,6 @@
5656 }
5757 this.emit( 'afterPush', childView );
5858 this.emit( 'update' );
59 - this.renderContent();
6059 };
6160
6261 es.DocumentViewBranchNode.prototype.onAfterUnshift = function( childModel ) {
@@ -69,7 +68,6 @@
7069 this.$.prepend( childView.$ );
7170 this.emit( 'afterUnshift', childView );
7271 this.emit( 'update' );
73 - childView.renderContent();
7472 };
7573
7674 es.DocumentViewBranchNode.prototype.onAfterPop = function() {
@@ -133,9 +131,10 @@
134132 this.emit.apply( this, ['afterSplice'].concat( args ) );
135133 if ( args.length >= 3 ) {
136134 for ( i = 2, length = args.length; i < length; i++ ) {
137 - args[i] = args[i].renderContent();
 135+ args[i].renderContent();
138136 }
139137 }
 138+ this.emit( 'update' );
140139 };
141140
142141 es.DocumentViewBranchNode.prototype.onAfterSort = function() {

Status & tagging log