r103405 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103404‎ | r103405 | r103406 >
Date:23:18, 16 November 2011
Author:inez
Status:deferred (Comments)
Tags:
Comment:
Minor fix.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/views/es.SurfaceView.js
——@@ -386,8 +386,9 @@
387387 var tx = this.documentView.model.prepareInsertion( this.selection.to, temp );
388388 this.documentView.model.commit( tx );
389389
390 - //this.selection.from = this.selection.to = this.documentView.getModel().getRelativeContentOffset( this.selection.to+1, 1 );
391 - //this.showCursor();
 390+ this.selection.from = this.selection.to = this.documentView.getModel().getRelativeContentOffset( this.selection.to, 1 );
 391+ this.showCursor();
 392+ e.preventDefault();
392393 }
393394 break;
394395 default: // Insert content (maybe)

Comments

#Comment by Bawolff (talk | contribs)   23:25, 16 November 2011

For future reference, "minor fix" isn't the greatest commit summary. Even if the fix is minor, it can still be helpful when looking through a large list of changes to be able to see what the change does.

Cheers

Status & tagging log