r103375 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103374‎ | r103375 | r103376 >
Date:20:36, 16 November 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
Reha and Sean's work to get the radio buttons to look like regular buttons and some other things
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -415,7 +415,7 @@
416416 }
417417 /* tooltip styling. by default the element to be styled is .tooltip */
418418 .tooltip {
419 - display:none;
 419+ display:none !important;
420420 background: #0F0;
421421 font-size:12px;
422422 height:70px;
@@ -436,31 +436,22 @@
437437 float: left;
438438 border: none;
439439 }
440 -.articleFeedbackv5-panel .trigger {
 440+.articleFeedbackv5-panel .articleFeedbackv5-tooltip-trigger {
441441 display: block;
442442 height: 27px;
443443 width: 26px;
444444 background: url(images/bg-tooltip-trigger.png) no-repeat;
445445 float: right;
446446 position: relative;
 447+ text-indent: -9999px;
447448 }
448 -.articleFeedbackv5-panel .trigger:hover {
 449+.articleFeedbackv5-panel .articleFeedbackv5-tooltip-trigger:hover {
449450 background: url(images/bg-tooltip-trigger-hov.png) no-repeat;
450451 cursor: pointer;
451452 text-decoration: none;
452453 }
453 -.articleFeedbackv5-panel .articleFeedbackv5-button-placeholder {
454 - display: inline-block;
455 - height: 20px;
456 - width: 50px;
457 - text-align: center;
458 - color: #fff;
459 - text-shadow: 1px 1px 1px #000;
460 - background: url(images/bg-button-disable.png) repeat-x;
461 - -moz-border-radius: 3px;
462 - -webkit-border-radius: 3px;
463 - border-radius: 3px; /* future proofing */
464 - -khtml-border-radius: 3px; /* for old Konqueror browsers */
 454+.articleFeedbackv5-panel .form-row {
 455+ margin: 0 0 15px;
465456 }
466457 .articleFeedbackv5-panel .instructions-left {
467458 float:left;
@@ -477,6 +468,19 @@
478469 .articleFeedbackv5-panel .buttons input {
479470 display: none;
480471 }
 472+.articleFeedbackv5-panel .buttons .articleFeedbackv5-button-placeholder {
 473+ display: inline-block;
 474+ height: 20px;
 475+ width: 50px;
 476+ text-align: center;
 477+ color: #fff;
 478+ text-shadow: 1px 1px 1px #000;
 479+ background: url(images/bg-button-disable.png) repeat-x;
 480+ -moz-border-radius: 3px;
 481+ -webkit-border-radius: 3px;
 482+ border-radius: 3px; /* future proofing */
 483+ -khtml-border-radius: 3px; /* for old Konqueror browsers */
 484+}
481485 .articleFeedbackv5-panel .buttons .articleFeedbackv5-button-placeholder:hover {
482486 background: url(images/bg-button.png) repeat-x;
483487 cursor: pointer;
@@ -495,12 +499,12 @@
496500 font-size: 14px;
497501 font: sans-serif;
498502 }
499 -.articleFeedbackv5-panel .articleFeedback-disclosure {
 503+.articleFeedbackv5-panel .articleFeedbackv5-disclosure {
500504 float: left;
501505 width: 235px;
502506 margin: 0 0 0 10px;
503507 }
504 -.articleFeedbackv5-panel .articleFeedback-submit {
 508+.articleFeedbackv5-panel .articleFeedbackv5-submit {
505509 float: right;
506510 height: 25px;
507511 width: 200px;
@@ -513,7 +517,7 @@
514518 border-radius: 3px; /* future proofing */
515519 -khtml-border-radius: 3px; /* for old Konqueror browsers */
516520 }
517 -.articleFeedbackv5-panel .articleFeedback-submit span {
 521+.articleFeedbackv5-panel .articleFeedbackv5-submit span {
518522 font-size: 16px;
519523 line-height: 15px;
520524 text-align: center;
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -133,7 +133,7 @@
134134 <form>\
135135 <div class="title-wrap">\
136136 <h2 class="articleFeedbackv5-title"><html:msg key="bucket1-title" /></h2>\
137 - <a class="articleFeedbackv5-tooltip-trigger">?</a>\
 137+ <a class="articleFeedbackv5-tooltip-trigger"></a>\
138138 <div class="articleFeedbackv5-tooltip">\
139139 <div class="tooltip-top"></div>\
140140 <div class="tooltip-repeat">\
@@ -160,6 +160,7 @@
161161 </div>\
162162 <div class="clear"></div>\
163163 </div>\
 164+ <div class="clear"></div>\
164165 </div>\
165166 <div class="articleFeedbackv5-comment">\
166167 <textarea id="find-feedback" class="feedback-text" name="comment"></textarea>\
@@ -218,12 +219,8 @@
219220 bindEvents: function ( $block ) {
220221
221222 // Tooltip
222 - $block.find( '.articleFeedbackv5-tooltip-trigger' ).hover( function () {
223 - // mouse on
224 - $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-tooltip' ).show();
225 - }, function () {
226 - // mouse off
227 - $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-tooltip' ).hide();
 223+ $block.find( '.articleFeedbackv5-tooltip-trigger' ).click( function () {
 224+ $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-tooltip' ).toggle();
228225 } );
229226
230227 // Enable submission and switch out the comment default on toggle selection

Status & tagging log